Revert "[CSS Env Vars] Add some WPT tests" #11644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 981a543f9e743001a6e492a006873de3a5953747. Reason for revert: These tests have been failing since they were added: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/20683 Original change's description: > [CSS Env Vars] Add some WPT tests > > Adds some WPT tests to test env() with @supports as well > as fallback values. > > BUG=825890 > > Change-Id: I071f5c2582f8056fe39b4a50ab62140d579c577d > Reviewed-on: https://chromium-review.googlesource.com/1111023 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569852} TBR=mlamouri@chromium.org,beccahughes@chromium.org,futhark@chromium.org Change-Id: I32fbe3682558bdd2d117c8f647750e5d8bcbf740 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825890 Reviewed-on: https://chromium-review.googlesource.com/1112982 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569916}
wpt-pr-bot
approved these changes
Jun 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 981a543f9e743001a6e492a006873de3a5953747.
Reason for revert:
These tests have been failing since they were added:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/20683
Original change's description:
TBR=mlamouri@chromium.org,beccahughes@chromium.org,futhark@chromium.org
Change-Id: I32fbe3682558bdd2d117c8f647750e5d8bcbf740
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 825890
Reviewed-on: https://chromium-review.googlesource.com/1112982
Reviewed-by: Nico Weber thakis@chromium.org
Commit-Queue: Nico Weber thakis@chromium.org
Cr-Commit-Position: refs/heads/master@{#569916}