Add a fail-fast for longtask layouttests #11837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2018
This CL adds checks to fail tests for browsers that do not support longtasks instead of forcing them to timeout. Change-Id: I5be54a1ab0a5d003decb58fc1e79380cbce15976 Reviewed-on: https://chromium-review.googlesource.com/1128174 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#573900}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1128174
branch
from
3936fa1
to
26245c1
Compare
|
This is blocked because /longtask-timing/longtask-in-sibling-iframe-crossorigin.html timed out once in https://travis-ci.org/web-platform-tests/wpt/jobs/402406108. Commented on the Chromium CL: The test was also already flaky in Chromium, see https://crbug.com/796668. Even without that bug, I would have argued that the test change couldn't plausibly have caused the timeout, it's a pre-existing problem. Therefore, force merging this, and treating https://crbug.com/796668 as the tracking bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds checks to fail tests for browsers that do not support longtasks
instead of forcing them to timeout.
Change-Id: I5be54a1ab0a5d003decb58fc1e79380cbce15976
Reviewed-on: https://chromium-review.googlesource.com/1128174
Reviewed-by: Timothy Dresser tdresser@chromium.org
Commit-Queue: Nicolás Peña Moreno npm@chromium.org
Cr-Commit-Position: refs/heads/master@{#573900}