Clean up the service-workers IDL test #11960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rring/web-platform-tests into idl-file-updates-service-workers
wpt-pr-bot
requested review from
asutherland,
jensl,
mfalken,
mkruisselbrink,
wanderview and
yuki3
foolip
approved these changes
Jul 22, 2018
There was a problem hiding this comment.
Tried to run locally but requires HTTPS and how to get that working locally isn't documented. @lukebjerring, did you run them locally, and were there sufficient docs for how?
|
AFAIK, You don't do anything special to get
|
|
Right, localhost is considered a secure context, problem is I was using http://web-platform.test:8000, and https://web-platform.test:8443 doesn't work unless you fiddle with the certs of your real browser, which I didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes some of the untested IDL copies in favor of
add_dependency_idls.