Update the css-images IDL file #11980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
foolip
reviewed
Jul 21, 2018
| // "CSS Images Module Level 4" spec. | ||
| // See: https://drafts.csswg.org/css-images-4/ | ||
|
|
||
| partial namespace CSS { |
There was a problem hiding this comment.
Namespaces now supported, but this will have to change after or together with an update of cssom.idl
There was a problem hiding this comment.
The test actually currently passes.. so it's clearly not asserting that it's a namespace. Will send you a PR.
There was a problem hiding this comment.
Filed after I reviewed this: #12123
css/css-images/idlharness.html
Outdated
|
|
||
| idl_test( | ||
| ['css-images'], | ||
| [], // No deps |
added 2 commits
July 23, 2018 09:59
lukebjerring
force-pushed
the
idl-file-updates-css-images
branch
from
2e49b37
to
3ed9040
Compare
foolip
approved these changes
Jul 23, 2018
|
Merging as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/directory (instead of inline copies in the test files).