Removing code duplication between XR layout tests and wpt tests #12188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing all the WebXR internal tests to use the test API specified in https://github.com/immersive-web/webxr-test-api. This will make tests more maintainable as changes to the backend mocking need only be made once. Bug: 863557 Change-Id: I4b8740269c0faa74073ef9294b6b27b78b18715a
wpt-pr-bot
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing all the WebXR internal tests to use the test API specified in
https://github.com/immersive-web/webxr-test-api. This will make tests
more maintainable as changes to the backend mocking need only be made
once.
Bug: 863557
Change-Id: I4b8740269c0faa74073ef9294b6b27b78b18715a
Reviewed-on: https://chromium-review.googlesource.com/1136982
WPT-Export-Revision: 0ccdbbae48a267dc8782b18e4c2f3d31e8b6b895