Add MediaStreamTrack Content Hints IDL file + test #12502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These tests pass on Chrome Dev with experimental web platform features enabled. |
lukebjerring
approved these changes
Aug 15, 2018
| }); | ||
|
|
||
| const stream = await getNoiseStream({ audio: true, video: true }); | ||
| self.audioTrack = stream.getAudioTracks()[0]; |
There was a problem hiding this comment.
Nit: Pull stream.getAudioTracks()[0] into a variable.
There was a problem hiding this comment.
But it has to be on the global object for add_objects to work, I presume using eval(). Am I misunderstanding?
There was a problem hiding this comment.
DW - Irrelevant given that there should have been 2 different values :)
|
|
||
| const stream = await getNoiseStream({ audio: true, video: true }); | ||
| self.audioTrack = stream.getAudioTracks()[0]; | ||
| self.videoTrack = stream.getAudioTracks()[0]; |
There was a problem hiding this comment.
The above nit assumes it was intended to re-use the same value. Is it? Or is there a getVideoTracks equivalent?
There was a problem hiding this comment.
Oops, copypasta, will fix.
alvestrand
approved these changes
Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.