[css-properties-values-api] Support string values in StylePropertyMap.set. #12547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 17, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1177755
branch
from
e09409a
to
a354c70
Compare
….set. When producing a CSSStyleValue from a string for a registered custom property, parse the value according to the syntax instead of always creating a CSSUnparsedValue. Note that <color> and <url> are still not supported, because CSSUnsupportedProperty does not work properly for registered custom properties (yet). R=futhark@chromium.org Bug: 641877 Change-Id: I806eb5b0c5112956e34457808791367423587c76 Reviewed-on: https://chromium-review.googlesource.com/1177755 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#587537}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1177755
branch
from
a354c70
to
0607426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When producing a CSSStyleValue from a string for a registered custom
property, parse the value according to the syntax instead of always
creating a CSSUnparsedValue.
Note that and are still not supported, because
CSSUnsupportedProperty does not work properly for registered custom
properties (yet).
R=futhark@chromium.org
Bug: 641877
Change-Id: I806eb5b0c5112956e34457808791367423587c76
Reviewed-on: https://chromium-review.googlesource.com/1177755
Commit-Queue: Anders Ruud andruud@chromium.org
Reviewed-by: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#587537}