Don't do whitespace re-attachment for ::first-letter. #12588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 21, 2018
If we have a white-space node before the text node with the first letter, we would try to re-attach the white-space node with an incorrect previous in-flow LayoutObject because we attach the ::first-letter after all children have been attached, not where the ::first-letter would end up in the layout tree. We don't need to re-attach whitespace after ::first-letter because: * We always create a remaining LayoutTextFragment for the text node which contains the first formatted letter. Wether the remaining text consists of white-space or is even empty. * If the LayoutObject sibling following first-letter+remaining-text consists of white-space, it would have gotten a LayoutObject when attaching the LayoutText for the text node where the first-letter comes from. That is, we will always have a LayoutObject for a white-space LayoutText sibling of a first-letter LayoutObject. Split out a separate method for ::first-letter for less complexity and cost with which WhitespaceAttacher to use. Bug: 876150 Change-Id: Ib1f34f0ba596d5fa5f1c7fcbd7c75550dd4f9d12 Reviewed-on: https://chromium-review.googlesource.com/1183231 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#584866}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1183231
branch
from
e93cf08
to
44b7734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have a white-space node before the text node with the first
letter, we would try to re-attach the white-space node with an incorrect
previous in-flow LayoutObject because we attach the ::first-letter after
all children have been attached, not where the ::first-letter would end
up in the layout tree.
We don't need to re-attach whitespace after ::first-letter because:
We always create a remaining LayoutTextFragment for the text node
which contains the first formatted letter. Wether the remaining text
consists of white-space or is even empty.
If the LayoutObject sibling following first-letter+remaining-text
consists of white-space, it would have gotten a LayoutObject when
attaching the LayoutText for the text node where the first-letter
comes from.
That is, we will always have a LayoutObject for a white-space LayoutText
sibling of a first-letter LayoutObject.
Split out a separate method for ::first-letter for less complexity and
cost with which WhitespaceAttacher to use.
Bug: 876150
Change-Id: Ib1f34f0ba596d5fa5f1c7fcbd7c75550dd4f9d12
Reviewed-on: https://chromium-review.googlesource.com/1183231
Reviewed-by: Xiaocheng Hu xiaochengh@chromium.org
Commit-Queue: Rune Lillesveen futhark@chromium.org
Cr-Commit-Position: refs/heads/master@{#584866}