Test that important flags are checked when serializing shorthand with "initial" values #12729
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +58,20 @@ | |||
| assert_equals(testElem.style.margin, "20px"); | |||
| assert_equals(testElem.style.cssText, "margin: 20px;") | |||
| }, "Shorthand serialization after setting"); | |||
|
|
|||
| test(function() { | |||
| var testElem = document.getElementById("test"); | |||
There was a problem hiding this comment.
Please, use 'let' or 'const' here.
| }, "Shorthand serialization with 'initial' value."); | ||
|
|
||
| test(function() { | ||
| var testElem = document.getElementById("test"); |
javifernandez
approved these changes
Aug 28, 2018
Loirooriol
force-pushed
the
css-shorthand-initial
branch
from
08ac4dd
to
acf0ab1
Compare
Loirooriol
added a commit
to Loirooriol/web-platform-tests
that referenced
this pull request
Sep 13, 2018
…rent important flags The initial test was added in web-platform-tests#12729 but some changes were requested in https://bugs.webkit.org/show_bug.cgi?id=188984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.webkit.org/show_bug.cgi?id=188984