Revert "[Image Capture] Add focusDistance constraint." #12852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3015459a9bf07f62ab7a8816ff88824568d87c04. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=880728 Original change's description: > [Image Capture] Add focusDistance constraint. > > This CL adds focusDistance to ImageCapture API. > This was added to the spec in > w3c/mediacapture-image#175 > > Layout tests and mock tests are updated to support the same. > Support for Android is added. > > TEST= run the demo in https://codepen.io/rijuB/pen/NzWpxG > use slider to change focusDistance. > > BUG=732807 > > Intent to Implement and Ship discussions: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oNxzXaFY9c8 > > Change-Id: I9b7cbf3c85fd35741a8c7ed229910a996e14ee8f > Reviewed-on: https://chromium-review.googlesource.com/1124839 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> > Cr-Commit-Position: refs/heads/master@{#588299} TBR=kinuko@chromium.org,rijubrata.bhaumik@intel.com,mcasas@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 732807 Change-Id: I03df3791095d9c0ef23c64990576140aebe7f52a
wpt-pr-bot
approved these changes
Sep 5, 2018
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3015459a9bf07f62ab7a8816ff88824568d87c04.
Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=880728
Original change's description:
TBR=kinuko@chromium.org,rijubrata.bhaumik@intel.com,mcasas@chromium.org,guidou@chromium.org
Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 732807
Change-Id: I03df3791095d9c0ef23c64990576140aebe7f52a
Reviewed-on: https://chromium-review.googlesource.com/1207350
WPT-Export-Revision: 92e1f23c9b7beedf14ee59017c4aa8c93a14e01a