ServiceWorker: Implement to return registration data after evaluate module scripts, and add WPT tests for ServiceWorker module scripts #12959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 12, 2018
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1205916
branch
9 times, most recently
from
461fff9
to
66d421b
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1205916
branch
from
66d421b
to
36dfcac
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1205916
branch
4 times, most recently
from
aa7cf7b
to
11edabd
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1205916
branch
6 times, most recently
from
8625a05
to
73c3564
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1205916
branch
4 times, most recently
from
df84d7f
to
3ad9d6f
Compare
module scripts, and add WPT tests for ServiceWorker module scripts Implement to return registration data after evaluate module scripts and commonize WillEvaluate/DidEvaluate functions of classic and module. In addition, import module tests for ServiceWorker scripts reuse tests for DedicatedWorker. The data path in both type is "Main scirpt -> Worker script -> Main scirpt" because ServiceWorker can reply to its source only in MessageEvent. Change-Id: I2bcc1670bd43109710af30c7df3aba5ff039201a Bug: 824647 Reviewed-on: https://chromium-review.googlesource.com/1205916 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#595369}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1205916
branch
from
3ad9d6f
to
6cb842a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement to return registration data after evaluate module scripts
and commonize WillEvaluate/DidEvaluate functions of classic and module.
In addition, import module tests for ServiceWorker scripts reuse tests
for DedicatedWorker. The data path in both type is "Main scirpt ->
Worker script -> Main scirpt" because ServiceWorker can reply to its
source only in MessageEvent.
Change-Id: I2bcc1670bd43109710af30c7df3aba5ff039201a
Bug: 824647
Reviewed-on: https://chromium-review.googlesource.com/1205916
Commit-Queue: Asami Doi <asamidoi@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595369}