[css-contain] Fix contain-size-025 using "dislay: block" on images #12960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was overflowing in Chromium in some configurations, because of the images were sitting on the alphabetic baseline and it varies depending on the font the browser selects. The test was trying to avoid the issue by using a 50x23 image, however that was not enough in some cases. The test is modified so it uses "display: block" for the images and 50x25 as size for them. This was discussed offline with @TalbotG.
frivoal
approved these changes
Sep 12, 2018
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 14, 2018
These tests had issues that have been fixed in WPT so they now pass: * contain-layout-cell-001 and contain-layout-cell-002 fixed by web-platform-tests/wpt#12926 * contain-size-025 fixed by web-platform-tests/wpt#12960 * contain-layout-formatting-context-margin-001.html fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1490111 Change-Id: I238fd8df20a99536d65815061e10b32b0d59f21f Reviewed-on: https://chromium-review.googlesource.com/1226591 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#591296}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was overflowing in Chromium in some configurations,
because of the images were sitting on the alphabetic baseline
and it varies depending on the font the browser selects.
The test was trying to avoid the issue by using a 50x23 image,
however that was not enough in some cases.
The test is modified so it uses "display: block" for the images
and 50x25 as size for them.
This was discussed offline with @TalbotG.