[css-properties-values-api] Detect font-relative units via var() refs. #13007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 14, 2018
The has[_root]_font_unit flags were accidentally ignored in one of CSSVariableData's constructors, and also not propagated properly during variable resolution. This caused us to lose any knowledge about these units if they appeared via an inner var() reference. Also: * Fix incorrect rem test which tested the wrong thing due to the 'compute_dimension' utility mutating its style. * Reduce the chance of such errors in the future by cleaning the state between every test, and also at the end of 'compute_dimension'. R=chrishtr@chromium.org Bug: 641877 Change-Id: If67cf4453e886f4c9430826c7cbe358e380c3f64 Reviewed-on: https://chromium-review.googlesource.com/1226492 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#591634}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1226492
branch
from
d9eb8c3
to
1c15a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The has[_root]_font_unit flags were accidentally ignored in one of
CSSVariableData's constructors, and also not propagated properly during
variable resolution. This caused us to lose any knowledge about these units
if they appeared via an inner var() reference.
Also:
'compute_dimension' utility mutating its style.
between every test, and also at the end of 'compute_dimension'.
R=chrishtr@chromium.org
Bug: 641877
Change-Id: If67cf4453e886f4c9430826c7cbe358e380c3f64
Reviewed-on: https://chromium-review.googlesource.com/1226492
Reviewed-by: Chris Harrelson chrishtr@chromium.org
Commit-Queue: Anders Ruud andruud@chromium.org
Cr-Commit-Position: refs/heads/master@{#591634}