Update interfaces/payment-handler.idl #13015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
requested changes
Sep 15, 2018
interfaces/payment-handler.idl
Outdated
| @@ -68,7 +75,9 @@ interface PaymentRequestEvent : ExtendableEvent { | |||
| readonly attribute object total; | |||
| readonly attribute FrozenArray<PaymentDetailsModifier> modifiers; | |||
| readonly attribute DOMString instrumentKey; | |||
| readonly attribute bool requestBillingAddress; | |||
There was a problem hiding this comment.
It says bool here instead of Boolean, I assume that will cause problems.
This was referenced Sep 15, 2018
autofoolip
force-pushed
the
reffy-reports/payment-handler
branch
from
931b7c8
to
225089a
Compare
foolip
approved these changes
Sep 16, 2018
|
Filed #13024 and then tested locally to confirm test still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by a bot.
Before merging, please check that any tests that depend on the updated IDL files still work.
If additional changes are needed, please manually create another PR based on this one.
See the README for how the IDL files in this directory are used.
Source: https://github.com/tidoust/reffy-reports/blob/5ac15fe/whatwg/idl/payment-handler.idl
Build: https://travis-ci.org/tidoust/reffy-reports/builds/429153951