Use MoveParagraphWithClones when moving paragraphs to new list items #13191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 24, 2018
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1216282
branch
2 times, most recently
from
63c9649
to
0fc173a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1216282
branch
9 times, most recently
from
93b434e
to
c316f30
Compare
The MoveParagraph function doesn't guarantee the paragraph's style is preserved when the insertOrderedList/insertOnordered list commands are used. Instead, we should use MoveParagraphWithClones. This change implies rebaseline a few tests, since the result tree is different than the one created with MoveParagraph. Bug: 149901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I01e5a9ade28d3c16e8dc5423bf16dcf0d7e60976 Reviewed-on: https://chromium-review.googlesource.com/c/1216282 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600342}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1216282
branch
from
c316f30
to
c994573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MoveParagraph function doesn't guarantee the paragraph's style is
preserved when the insertOrderedList/insertOnordered list commands
are used.
Instead, we should use MoveParagraphWithClones. This change implies
rebaseline a few tests, since the result tree is different than the
one created with MoveParagraph.
Bug: 149901
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I01e5a9ade28d3c16e8dc5423bf16dcf0d7e60976
Reviewed-on: https://chromium-review.googlesource.com/c/1216282
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600342}