[css-contain] Layout|Size containment and baseline in flexbox|grid #13254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Sep 28, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1250524
branch
2 times, most recently
from
c87454d
to
c82ef81
Compare
In r591642 we updated the behavior so layout containment suppress baseline alignment, while size containment does not. However, we forgot about the special cases (flexbox and grid) that have their own code for this, which are fixed in this patch. Regarding WPT tests, these changes will fix the following issue: #13252 One of the Mozilla tests is failing now, it was mentioned in the associated bug report (https://bugzilla.mozilla.org/1491235). BUG=882333 TEST=external/wpt/css/css-contain/contain-layout-button-001.html TEST=external/wpt/css/css-contain/contain-layout-flexbox-001.html TEST=external/wpt/css/css-contain/contain-layout-grid-001.html TEST=external/wpt/css/css-contain/contain-size-button-001.html TEST=external/wpt/css/css-contain/contain-size-flexbox-001.html TEST=external/wpt/css/css-contain/contain-size-grid-001.html Change-Id: I5e437d7f82d07d2f6222416a1eb9a3b89cb44eca Reviewed-on: https://chromium-review.googlesource.com/1250524 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595105}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1250524
branch
from
c82ef81
to
76de073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In r591642 we updated the behavior so layout containment
suppress baseline alignment, while size containment does not.
However, we forgot about the special cases (flexbox and grid)
that have their own code for this, which are fixed in this patch.
Regarding WPT tests, these changes will fix the following issue:
#13252
One of the Mozilla tests is failing now, it was mentioned
in the associated bug report (https://bugzilla.mozilla.org/1491235).
BUG=882333
TEST=external/wpt/css/css-contain/contain-layout-button-001.html
TEST=external/wpt/css/css-contain/contain-layout-flexbox-001.html
TEST=external/wpt/css/css-contain/contain-layout-grid-001.html
TEST=external/wpt/css/css-contain/contain-size-button-001.html
TEST=external/wpt/css/css-contain/contain-size-flexbox-001.html
TEST=external/wpt/css/css-contain/contain-size-grid-001.html
Change-Id: I5e437d7f82d07d2f6222416a1eb9a3b89cb44eca
Reviewed-on: https://chromium-review.googlesource.com/1250524
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595105}