[css-layout-api] Add LayoutEdges. #13291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 1, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1252776
branch
2 times, most recently
from
4eeb0f6
to
b29df61
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1252776
branch
from
b29df61
to
357f307
Compare
This allows web developers to access pre-computed sizes for the border, scrollbar, and padding "edges". This adds two types of tests: 1) Uses the standard "green box" approach of testing the script values match what is expected. 2) Positions four children at each corner (using edges) are positioned the same as using an abs-pos technique. Bug: 726125 Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b Reviewed-on: https://chromium-review.googlesource.com/c/1252776 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#599680}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1252776
branch
from
357f307
to
50bc27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows web developers to access pre-computed sizes for the border,
scrollbar, and padding "edges".
This adds two types of tests:
match what is expected.
the same as using an abs-pos technique.
Bug: 726125
Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b
Reviewed-on: https://chromium-review.googlesource.com/c/1252776
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599680}