Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1498734] Always compute angle values to degrees. #13500

Merged
merged 1 commit into from Oct 13, 2018

Commits on Oct 13, 2018

  1. Always compute angle values to degrees.

    This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:
    
    > All <angle> units are compatible, and deg is their canonical unit.
    
    And https://drafts.csswg.org/css-values/#compat, which says:
    
    >When serializing computed values [...], compatible units [...] are converted into a single canonical unit.
    
    And also other implementations (Blink always serializes angles as degrees in
    computed style for example).
    
    Also allows us to get rid of quite a bit of code, and makes computed angle value
    representation just a number, which is nice.
    
    Differential Revision: https://phabricator.services.mozilla.com/D8619
    
    bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1498734
    gecko-commit: 7584ce8674c21dfedc59ecc712eabb94306a2ba2
    gecko-integration-branch: central
    gecko-reviewers: xidorn
    emilio authored and moz-wptsync-bot committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    e575077 View commit details
    Browse the repository at this point in the history