Revert "[css-layout-api] Add LayoutEdges." #13537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 980bc9b6532b0980721c123fa29fa561bc503f91. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599680 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTgwYmM5YjY1MzJiMDk4MDcyMWMxMjNmYTI5ZmE1NjFiYzUwM2Y5MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414 Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5 Sample Flaky Test: external/wpt/css/css-layout-api/edges/scrollbar.https.html Original change's description: > [css-layout-api] Add LayoutEdges. > > This allows web developers to access pre-computed sizes for the border, > scrollbar, and padding "edges". > > This adds two types of tests: > 1) Uses the standard "green box" approach of testing the script values > match what is expected. > 2) Positions four children at each corner (using edges) are positioned > the same as using an abs-pos technique. > > Bug: 726125 > Change-Id: I3b53be9b44989d919cb657d4eabc6d3a1a79181b > Reviewed-on: https://chromium-review.googlesource.com/c/1252776 > Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Aleks Totic <atotic@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599680} Change-Id: Ib4f9cb3e51daa57412d31cff71cbf0a3fe15cab9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 726125, 895731 Reviewed-on: https://chromium-review.googlesource.com/c/1282724 Cr-Commit-Position: refs/heads/master@{#599889}
wpt-pr-bot
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 980bc9b6532b0980721c123fa29fa561bc503f91.
Reason for revert:
Findit (https://goo.gl/kROfz5) identified CL at revision 599680 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTgwYmM5YjY1MzJiMDk4MDcyMWMxMjNmYTI5ZmE1NjFiYzUwM2Y5MQw
Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/35414
Sample Failed Step: webkit_layout_tests on (none) GPU on Mac on Mac-10.10.5
Sample Flaky Test: external/wpt/css/css-layout-api/edges/scrollbar.https.html
Original change's description:
Change-Id: Ib4f9cb3e51daa57412d31cff71cbf0a3fe15cab9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 726125, 895731
Reviewed-on: https://chromium-review.googlesource.com/c/1282724
Cr-Commit-Position: refs/heads/master@{#599889}