[css-flexbox] Apply min-height: auto to nested flexboxes again #13550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 16, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1269235
branch
3 times, most recently
from
05f6b90
to
be312f7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1269235
branch
6 times, most recently
from
b704a6b
to
5947d94
Compare
This was made possible by crrev.com/c/1283482, which avoids the performance and correctness issues this previously caused. This relands crrev.com/c/1246730 / crrev.com/c/1252682. The ChromeOS UI breakage was fixed by crrev.com/c/1281726 and crrev.com/c/1282462 IF THIS BREAKS ANY FURTHER CHROME UI: Please don't revert this patch; instead, add min-height: 0 to any inner nested flexboxes that may be affected by this patch. This is an important change for web interop with the other browsers. Bug: 596743 Change-Id: I9afe54dce82d41da452d1fdca8150ca22ebb6f9c Reviewed-on: https://chromium-review.googlesource.com/c/1269235 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601540}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1269235
branch
from
5947d94
to
dffb313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was made possible by crrev.com/c/1283482, which avoids the
performance and correctness issues this previously caused.
This relands crrev.com/c/1246730 / crrev.com/c/1252682. The ChromeOS UI
breakage was fixed by crrev.com/c/1281726 and crrev.com/c/1282462
IF THIS BREAKS ANY FURTHER CHROME UI:
Please don't revert this patch; instead, add min-height: 0 to any
inner nested flexboxes that may be affected by this patch. This is
an important change for web interop with the other browsers.
Bug: 596743
Change-Id: I9afe54dce82d41da452d1fdca8150ca22ebb6f9c
Reviewed-on: https://chromium-review.googlesource.com/c/1269235
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601540}