[css-multicol] Initial values and inheritance #13651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that CSS Multi-column Layout properties have the initial values given in the spec. None of the properties inherit. https://drafts.csswg.org/css-multicol/#property-index Identified bugs: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19367855/ https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19367975/ https://bugs.webkit.org/show_bug.cgi?id=190702
mstensho
approved these changes
Oct 22, 2018
css/css-multicol/inheritance.html
Outdated
| <meta charset="utf-8"> | ||
| <title>Inheritance of CSS Multi-column Layout properties</title> | ||
| <link rel="help" href="https://drafts.csswg.org/css-multicol/#property-index"> | ||
| <meta name="assert" content="Properties not not inherit."> |
There was a problem hiding this comment.
Suggested change
| <meta name="assert" content="Properties not not inherit."> | |
| <meta name="assert" content="Properties should not inherit."> |
| const mediumWidth = getComputedStyle(reference).borderTopWidth; // e.g. 3px | ||
| reference.style.display = 'none'; | ||
|
|
||
| assert_not_inherited('column-count', 'auto', '2'); |
There was a problem hiding this comment.
These are generally hard to read. Probably because I'm not used to these functions. How about documenting the functions in /css/support/inheritance-testcommon.js ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that CSS Multi-column Layout properties have the initial values
given in the spec. None of the properties inherit.
https://drafts.csswg.org/css-multicol/#property-index
Identified bugs: