Revert "Reland "bindings: Implement timers with V8Function"" #13674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 17f4e7d2ec13d6112dfcd8aa253f340bdb00d395. Reason for revert: Still breaks ASAN Original change's description: > Reland "bindings: Implement timers with V8Function" > > This is a reland of 254369a5f6df06c2c6be067d14c2cb2a036ba173. It addresses bug > 888025 by adding ASAN test expectations, as the relevant V8 feature does not > yet support running on ASAN builds. > > Original change's description: > > bindings: Implement timers with V8Function > > > > This fixes bug 866610 by using the IDL infrastructure to properly enter > > the v8::Context before calling the registered callback. > > > > Also ensure eager finalization of ScheduledAction in DOMTimer to > > prevent a memory leak. Added two more effective DCHECKs to confirm. > > > > Bug: 866610 > > Change-Id: I37d7bd05f035fe31856cfe68bae51aa0632cd3b1 > > Reviewed-on: https://chromium-review.googlesource.com/1220486 > > Reviewed-by: Nate Chapin <japhet@chromium.org> > > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Timothy Gu <timothygu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593108} > > TBR=japhet@chromium.org > > Bug: 866610, 888025 > Change-Id: Iee5c1d6917ad7770383e06a425f96000835a663a > Reviewed-on: https://chromium-review.googlesource.com/c/1239624 > Reviewed-by: Nate Chapin <japhet@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Timothy Gu <timothygu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601830} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org Change-Id: Ie4f45dfcc1adcc2ac3469eab99dba813723288f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866610, 888025 Reviewed-on: https://chromium-review.googlesource.com/c/1296057 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#601864}
wpt-pr-bot
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 17f4e7d2ec13d6112dfcd8aa253f340bdb00d395.
Reason for revert: Still breaks ASAN
Original change's description:
TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org,japhet@chromium.org,timothygu@chromium.org
Change-Id: Ie4f45dfcc1adcc2ac3469eab99dba813723288f4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 866610, 888025
Reviewed-on: https://chromium-review.googlesource.com/c/1296057
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601864}