Window onerror is not triggered bug fix #13691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 23, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1287208
branch
from
1b1be90
to
b937a71
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1287208
branch
5 times, most recently
from
4bca286
to
c68bc9e
Compare
As pointed out in the bug, unhandled errors on worker threads were not properly being propagated for the parent thread to handle as the spec requires (https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2). This fix adds in the code to do that. Bug: 685303 Change-Id: Ie3e7ec03153a43efdc6e70b874d6b1a1d8ac35ef Reviewed-on: https://chromium-review.googlesource.com/c/1287208 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605857}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1287208
branch
from
c68bc9e
to
bf67a6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in the bug, unhandled errors on worker threads were not
properly being propagated for the parent thread to handle as the spec
requires (https://html.spec.whatwg.org/multipage/workers.html#runtime-script-errors-2).
This fix adds in the code to do that.
Bug: 685303
Change-Id: Ie3e7ec03153a43efdc6e70b874d6b1a1d8ac35ef
Reviewed-on: https://chromium-review.googlesource.com/c/1287208
Commit-Queue: Katie Dillon <kdillon@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605857}