ServiceWorker: Add new tests for updating the registration with different script type. #13692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 24, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1295763
branch
from
d726da6
to
78b0bb1
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1295763
branch
6 times, most recently
from
b9ea12b
to
ec6574d
Compare
different script type. These tests check that a registration is updated correctly with different script type. At first Service Worker is register as classic script type, then it is re-registered as module script type, and vice versa. A main script is also updated at the same time. Bug: 824647 Change-Id: I3ab9391791508662de8dc73ac932a6105c4d7fe6 Reviewed-on: https://chromium-review.googlesource.com/c/1295763 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602650}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1295763
branch
from
ec6574d
to
644afb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests check that a registration is updated correctly with
different script type. At first Service Worker is register as classic
script type, then it is re-registered as module script type, and
vice versa. A main script is also updated at the same time.
Bug: 824647
Change-Id: I3ab9391791508662de8dc73ac932a6105c4d7fe6
Reviewed-on: https://chromium-review.googlesource.com/c/1295763
Commit-Queue: Asami Doi <asamidoi@google.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602650}