Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTCPeerConnection-setRemoteDescription-tracks.https.html as MediaStream has no constraint on the order of the tracks #13940

Merged
merged 1 commit into from Nov 6, 2018
Merged

Update RTCPeerConnection-setRemoteDescription-tracks.https.html as MediaStream has no constraint on the order of the tracks #13940

merged 1 commit into from Nov 6, 2018

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 6, 2018

No description provided.

@youennf
Update RTCPeerConnection-setRemoteDescription-tracks.https.html as Me…
21c759a 
…diaStream has no constraint on the order of the track
@youennf youennf changed the title Update RTCPeerConnection-setRemoteDescription-tracks.https.html as MediaStream has no constraint on the order of the track Update RTCPeerConnection-setRemoteDescription-tracks.https.html as MediaStream has no constraint on the order of the tracks Nov 6, 2018
henbos
henbos approved these changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order that tracks are added to the stream is well-defined, but I see that getTracks() isn't:
"The conversion from the track set to the sequence is User Agent defined and the order does not have to be stable between calls."
LGTM

@youennf youennf merged commit 89c900d into web-platform-tests:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henbos henbos henbos approved these changes

@agouaillard agouaillard Awaiting requested review from agouaillard

@alvestrand alvestrand Awaiting requested review from alvestrand

@dontcallmedom dontcallmedom Awaiting requested review from dontcallmedom

@guidou guidou Awaiting requested review from guidou

@phoglund phoglund Awaiting requested review from phoglund

@rwaldron rwaldron Awaiting requested review from rwaldron

@snuggs snuggs Awaiting requested review from snuggs

Assignees
No one assigned
Labels
webrtc wg-webrtc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youennf @henbos @wpt-pr-bot