Fix CSSPreloadScanner to avoid missing rules #14014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 10, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1331042
branch
4 times, most recently
from
57a5415
to
2f8c4f4
Compare
This fixes a couple of bugs with the CSSPReloadScanner that made it miss rules in which the URL wasn't quoted or the rule didn't end with a semicolon. It also adds tentative WPT tests for that functionality, as the tests are also relevant for WebKit. Bug: 903785 Change-Id: I6d7dae1db3617184148fd71dfdb62fa1ee19e74f
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1331042
branch
from
2f8c4f4
to
2335b8f
Compare
|
Close this PR because the Chromium CL does not have exportable changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of bugs with the CSSPReloadScanner that made it miss
rules in which the URL wasn't quoted or the rule didn't end with a
semicolon. It also adds tentative WPT tests for that functionality, as
the tests are also relevant for WebKit.
Bug: 903785
Change-Id: I6d7dae1db3617184148fd71dfdb62fa1ee19e74f
Reviewed-on: https://chromium-review.googlesource.com/1331042
WPT-Export-Revision: bd38933d7e615147421b6bdddf52b74b971c065e