Fix serialization of computed style for 'paint-order' #14077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 15, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1335579
branch
from
0e217d9
to
78a410a
Compare
We were always serializing as the completed (all keywords present) form, which is not the shortest canonical form. https://svgwg.org/svg2-draft/painting.html#PaintOrder Fold the ComputedStyleUtils helper into the PaintOrder CSSProperty class, since this is very specific to this property. Matches WebKit and almost Gecko (which seems to handle some "two keyword" cases differently.) Bug: 904898 Change-Id: Ib796a111e601485e339fdf2739a587fb5f893b8a Reviewed-on: https://chromium-review.googlesource.com/c/1335579 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#608623}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1335579
branch
from
78a410a
to
1dc2f97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always serializing as the completed (all keywords present) form,
which is not the shortest canonical form.
https://svgwg.org/svg2-draft/painting.html#PaintOrder
Fold the ComputedStyleUtils helper into the PaintOrder CSSProperty
class, since this is very specific to this property.
Matches WebKit and almost Gecko (which seems to handle some "two
keyword" cases differently.)
Bug: 904898
Change-Id: Ib796a111e601485e339fdf2739a587fb5f893b8a
Reviewed-on: https://chromium-review.googlesource.com/c/1335579
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608623}