[css-grid] Fix grid container sizing under min-content height #14100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 16, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1340311
branch
from
03fe40a
to
5d5ed03
Compare
The spec is quite clear (https://drafts.csswg.org/css-sizing/#valdef-width-min-content): "min-content If specified for the inline axis, use the min-content inline size; otherwise behaves as the property’s initial value." So if a grid container has "height: min-content" it should behave the same than with "height: auto". The patch removes ComputeIntrinsicLogicalContentHeightUsing() in LayoutGrid as we don't need a custom one anymore. We can also get rid of min_content_height_ and max_content_height_ attributes that were only used for this logic. BUG=906039 TEST=fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html TEST=fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html Change-Id: Ia67d1dac16fbb04e3225115c3f34c67975dc6f94 Reviewed-on: https://chromium-review.googlesource.com/c/1340311 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#610059}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1340311
branch
from
5d5ed03
to
f4fcb73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec is quite clear
(https://drafts.csswg.org/css-sizing/#valdef-width-min-content):
"min-content
If specified for the inline axis, use the min-content inline size;
otherwise behaves as the property’s initial value."
So if a grid container has "height: min-content" it should behave
the same than with "height: auto".
The patch removes ComputeIntrinsicLogicalContentHeightUsing() in
LayoutGrid as we don't need a custom one anymore.
We can also get rid of min_content_height_ and max_content_height_
attributes that were only used for this logic.
BUG=906039
TEST=fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html
TEST=fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html
Change-Id: Ia67d1dac16fbb04e3225115c3f34c67975dc6f94
Reviewed-on: https://chromium-review.googlesource.com/c/1340311
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610059}