webrtc-wpt: use addTrack(track, stream) to increase firefox compat #14170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 21, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1346394
branch
6 times, most recently
from
8c25182
to
f890e1d
Compare
Firefox does not support addTrack(track). Add a track whereever it makes sense. The addTrack tests itself might rightfully use this. The following grep shows most affected places: git grep addTrack *.html | grep -v , | grep -v "\.\.\." Bug: None Change-Id: Ib225e6d51184c3ccc446ccf93447e2ac7be080c3 Reviewed-on: https://chromium-review.googlesource.com/c/1346394 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#611262}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1346394
branch
from
f890e1d
to
8c285bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox does not support addTrack(track). Add a track whereever it makes sense.
The addTrack tests itself might rightfully use this.
The following grep shows most affected places:
git grep addTrack *.html | grep -v , | grep -v "..."
Bug: None
Change-Id: Ib225e6d51184c3ccc446ccf93447e2ac7be080c3
Reviewed-on: https://chromium-review.googlesource.com/c/1346394
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#611262}