Don't estimate the top of bottom-aligned OOFs as bottom. #14311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 30, 2018
We'll incorrectly think that we get fragmented in that case, which will lead to incorrect height, which will lead to incorrect top offset, which will lead to incorrect fragmentation. This has probably been the cause for a flaky web test, that behaved even worse in LayoutNG, because in NG we force legacy layout as soon as fragmentation is involved (so when entering printing, we typically need to rebuild the entire layout object tree, with no former height to base the bottom estimate on (which is what saved us when NG is disabled - ehm, at least most of the time)). Bug: 910300 Change-Id: I8e152f77e9a94bb05e51f02a24be6ef5fe03c6f9 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1355920 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#613930}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1355920
branch
from
fa09bb3
to
a564887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll incorrectly think that we get fragmented in that case, which will
lead to incorrect height, which will lead to incorrect top offset,
which will lead to incorrect fragmentation.
This has probably been the cause for a flaky web test, that behaved
even worse in LayoutNG, because in NG we force legacy layout as soon as
fragmentation is involved (so when entering printing, we typically need
to rebuild the entire layout object tree, with no former height to base
the bottom estimate on (which is what saved us when NG is disabled -
ehm, at least most of the time)).
Bug: 910300
Change-Id: I8e152f77e9a94bb05e51f02a24be6ef5fe03c6f9
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1355920
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613930}