[CSS] Fix test for css invalidation so that it fails without ::part. #14428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 10, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1369500
branch
from
ee6aab2
to
40fed03
Compare
The test was testing that the element ended up green (starting red) however, if the browser has no support at all for ::part then the element actually starts green and stays green. Bug: 805271 Change-Id: Ida40c7963aa3a00c3d197b1309ddaea49e4f3b92 Reviewed-on: https://chromium-review.googlesource.com/c/1369500 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615435}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1369500
branch
from
40fed03
to
03d6f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was testing that the element ended up green (starting red)
however, if the browser has no support at all for ::part then the
element actually starts green and stays green.
Bug: 805271
Change-Id: Ida40c7963aa3a00c3d197b1309ddaea49e4f3b92
Reviewed-on: https://chromium-review.googlesource.com/c/1369500
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615435}