WPT: CSS: Add same-origin tests for loading error stylesheets. #14458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test that a stylesheet that failed to load is considered cross-origin. That is, accessing |styleSheet.rules| throws a SecurityError. This aligns with the specifications: - cssRules checks the `origin-clean` flag: https://drafts.csswg.org/cssom/#dom-cssstylesheet-cssrules - This is set to true iff CORS-same-origin: https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet - CORS-same-origin is false for "error" responses: https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-same-origin Bug: 911974 Change-Id: I558e6d3dfa564b15284c393ffc35b80f54a9bc4e Reviewed-on: https://chromium-review.googlesource.com/c/1371307 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615479}
wpt-pr-bot
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test that a stylesheet that failed to load is considered
cross-origin. That is, accessing |styleSheet.rules| throws a
SecurityError. This aligns with the specifications:
origin-cleanflag:https://drafts.csswg.org/cssom/#dom-cssstylesheet-cssrules
https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet
https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-same-origin
Bug: 911974
Change-Id: I558e6d3dfa564b15284c393ffc35b80f54a9bc4e
Reviewed-on: https://chromium-review.googlesource.com/c/1371307
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615479}