Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LayoutNG] Don't allow line height quirk inside list items. #14623

Merged
merged 1 commit into from Dec 20, 2018

Commits on Dec 20, 2018

  1. [LayoutNG] Don't allow line height quirk inside list items.

    This makes us match legacy engine behavior more closely, and both Edge
    and Firefox have something similar, although Firefox triggers based on
    element type (LI), and not display type (list-item). There's currently
    nothing in the spec [1] that suggests such special behavior for list
    items.
    
    [1] https://quirks.spec.whatwg.org/#the-line-height-calculation-quirk
    
    This fix makes the line height differences go away in the test
    tables/mozilla/bugs/bug23235.html (but note that it will still require
    a rebaseline, because of minor text rendering differences between
    legacy and NG).
    
    See whatwg/quirks#38 for spec discussion.
    
    Change-Id: I396c0c85454feeaa45a0a5953b9e6b7c475d131e
    Reviewed-on: https://chromium-review.googlesource.com/c/1379897
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#618304}
    mstensho authored and chromium-wpt-export-bot committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    66d1667 View commit details
    Browse the repository at this point in the history