Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-text] Check interraction of tab-size, letter-spacing, word-spacing #14679

Merged

Conversation

frivoal
Copy link
Contributor

@frivoal frivoal commented Dec 28, 2018

No description provided.

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frivoal frivoal added the wg-css label Dec 28, 2018
@frivoal
Copy link
Contributor Author

frivoal commented Dec 28, 2018

@fantasai @kojiishi I think I got this right, but it's failing (differently) in all browsers, so I wouldn't mind a quick sanity-check review.

@frivoal frivoal self-assigned this Dec 28, 2018
@fantasai
Copy link
Contributor

Looks correct to me. However, I would not use the overlapping technique for this one if there's a problem with antialiasing. I'd just stack the references and say something like “There should be a blue square with perfectly smooth sides below.” or something, and make each one a 2:1 rectangle.

@frivoal
Copy link
Contributor Author

frivoal commented Jan 11, 2019

Looks correct to me.

Cool.

However, I would not use the overlapping technique for this one if there's a problem with antialiasing. I'd just stack the references and say something like “There should be a blue square with perfectly smooth sides below.” or something, and make each one a 2:1 rectangle.

I'm actually going to disagree. With the technique your proposing, it's harder to be sure you're in the pass case. If the two halves really don't line up, then the failure will be clear. But if they do, this kind of tests/phrasing will encourage people to squint hard at the screen to try and decide whether the edges are sufficiently smooth... And if the positioning is off by less than 1px, neither nor variant nor mine are very good at catching that. But I'd consider that a matter of precision rather than correctness, and so I don't think this is something we should try to catch.

Anyway. Merging. If you feel strongly about that, let's open a new issue or PR to follow up.

@frivoal frivoal merged commit 3021369 into web-platform-tests:master Jan 11, 2019
@frivoal frivoal deleted the tab-size-letter-word-spacing branch January 11, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants