Augment set of WPT tests for interpolation of transform lists. #14695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 2, 2019
This patch improves test coverage for the interpolation of transform lists. Specifically, the new tests cover: * mismatched list lengths with a partial prefix match * mix of exact and primitive (e.g. scaleX & scaleY --> scale) matches These new tests fail in Chrome without the patch (https://chromium-review.googlesource.com/c/chromium/src/+/1372025) to implement the algorithm outlined in transforms spec (https://drafts.csswg.org/css-transforms-1/#interpolation-of-transforms), but pass when tested in Firefox version 64.0. Bug: 918643 Change-Id: I65bfe5b3c13c2fb33b3d2b926dc153135b140a63 Reviewed-on: https://chromium-review.googlesource.com/c/1393460 Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#619635}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1393460
branch
from
8c2744e
to
c5f304d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves test coverage for the interpolation of transform lists. Specifically, the new tests cover:
These new tests fail in Chrome without the patch (https://chromium-review.googlesource.com/c/chromium/src/+/1372025) to implement the algorithm outlined in transforms spec (https://drafts.csswg.org/css-transforms-1/#interpolation-of-transforms), but pass when tested in Firefox version 64.0.
Bug: 918643
Change-Id: I65bfe5b3c13c2fb33b3d2b926dc153135b140a63
Reviewed-on: https://chromium-review.googlesource.com/c/1393460
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619635}