Add CEReactions tests #14711
Merged
Add CEReactions tests #14711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTMLMapElement - HTMLCanvasElement - HTMLDataElement - HTMLDetailsElement - HTMLModElement - HTMLOListElement - HTMLQuoteElement - HTMLSlotElement - HTMLTimeElement
wpt-pr-bot
requested review from
domenic,
hayatoito,
kojiishi,
rniwa,
snuggs and
TakayoshiKochi
|
w3c-test:mirror |
domenic
requested changes
Jan 24, 2019
|
|
||
| <script> | ||
|
|
||
| testReflectAttribute('open', 'open', 'true', 'false', 'open on HTMLDetailsElement', 'details', HTMLDetailsElement); |
There was a problem hiding this comment.
Boolean attributes don't get reflected by the strings "true" and "false". They get reflected by the removal or addition of the attribute.
|
|
||
| <script> | ||
|
|
||
| testReflectAttribute('cite', 'cite', '../resources/custom-elements-helpers.js', './resources/reactions.js', 'cite on ins use HTMLModElement', 'ins', HTMLModElement); |
There was a problem hiding this comment.
This test fails on Chrome. I believe it is because the attribute name is datetime, not dateTime.
|
|
||
| <script> | ||
|
|
||
| testReflectAttribute('reversed', 'reversed', 'true', 'false', 'reversed on HTMLOListElement', 'ol', HTMLOListElement); |
There was a problem hiding this comment.
Boolean attributes problem again
|
|
||
| <script> | ||
|
|
||
| testReflectAttribute('dateTime', 'dateTime', '2018-12-10', '2018-12-12', 'dateTime on HTMLTimeElement', 'time', HTMLTimeElement); |
There was a problem hiding this comment.
Also fails on Chrome, also I guess for the same reason.
- Use "datetime" as the attribute name. - Modify the tests for boolean attributes.
|
@domenic, many thanks for your review! I just submit a new commit to address your comments, PTAL. |
|
w3c-test:mirror |
domenic
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of issue #5727