[css-grid] Fix auto repeat with multiple tracks and gutters #14718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 4, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1393136
branch
2 times, most recently
from
c6bd4d0
to
9836664
Compare
The code that computes the number of auto repeat tracks wrongly assumes that the second argument of the repeat() notation is a single track function. That was true in the beginning, however specs were later on modified to allow a <track-list>. We support a <track-list> as a second argument since long ago but the code that computes the number of auto-repeat tracks was never updated. This patch modifies two places that relates to the gaps between the auto-repeat tracks, which ensures the proper total length. 4 test expected values in the auto-repeat-huge-grid.html are also modified. BUG=813511 Change-Id: Iaf00e7d595a800f07cbe630868f30b82ad7fbd4d Reviewed-on: https://chromium-review.googlesource.com/c/1393136 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#620278}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1393136
branch
from
9836664
to
d8d8b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that computes the number of auto repeat tracks wrongly assumes
that the second argument of the repeat() notation is a single track
function. That was true in the beginning, however specs were later on
modified to allow a <track-list>. We support a <track-list> as a second
argument since long ago but the code that computes the number of
auto-repeat tracks was never updated.
This patch modifies two places that relates to the gaps between the
auto-repeat tracks, which ensures the proper total length. 4 test
expected values in the auto-repeat-huge-grid.html are also modified.
BUG=813511
Change-Id: Iaf00e7d595a800f07cbe630868f30b82ad7fbd4d
Reviewed-on: https://chromium-review.googlesource.com/c/1393136
Commit-Queue: Manuel Rego <rego@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#620278}