Move outputContext from XRSession to XRRenderState #15507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 21, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1476097
branch
3 times, most recently
from
495088a
to
9de8bfb
Compare
This requires all sessions that were previously setting an outputContext in the requestSession call to move that assignment to an updateRenderState call post-session-creation instead. Additionally, "inline" sessions can now be created without an outputContext but must still have one assigned to them before any requestAnimationFrame callbacks will be processed. Bug: 928417 Change-Id: I469fab8c3f641870387f2f92aee52182016efe37 Reviewed-on: https://chromium-review.googlesource.com/c/1476097 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#636557}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1476097
branch
from
9de8bfb
to
d8b4ebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires all sessions that were previously setting an
outputContext in the requestSession call to move that assignment to an
updateRenderState call post-session-creation instead. Additionally,
"inline" sessions can now be created without an outputContext but must
still have one assigned to them before any requestAnimationFrame
callbacks will be processed.
Bug: 928417
Change-Id: I469fab8c3f641870387f2f92aee52182016efe37
Reviewed-on: https://chromium-review.googlesource.com/c/1476097
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636557}