Exposing RID attribute in RTCRtpCodingParameters. #15531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 22, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1483352
branch
2 times, most recently
from
d9cbf0d
to
9e5187f
Compare
The RID attribute needs to be supplied when setting up simulcast using addTransceiver() and when updating the encoding parameters on the sender when simulcast is used (getParameters(), setParameters()). This change exposes the RIDs and validates that they cannot be modified when changing parameters on the sender. Bug: webrtc:10299 Bug: chromium:857034 Change-Id: I8b4bfa2b362ab5851a95c6fb90cc385daa4f651f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483352 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637338}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1483352
branch
from
9e5187f
to
87eaed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RID attribute needs to be supplied when setting up simulcast using
addTransceiver() and when updating the encoding parameters on the sender
when simulcast is used (getParameters(), setParameters()).
This change exposes the RIDs and validates that they cannot be modified
when changing parameters on the sender.
Bug: webrtc:10299
Bug: chromium:857034
Change-Id: I8b4bfa2b362ab5851a95c6fb90cc385daa4f651f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483352
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Amit Hilbuch <amithi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637338}