Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WPT] Move subresource_path from generator to referrer-policy-test-case.js #15539

Merged
merged 1 commit into from Feb 26, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 23, 2019

As a preparation for merging generator scripts.

Changes to generated HTMLs are split into a subsequent CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1476172

Bug: 906850
Change-Id: I942159ce3b57dd472fe56764772b610c0231132f
Reviewed-on: https://chromium-review.googlesource.com/c/1476144
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634993}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

…se.js

As a preparation for merging generator scripts.

Changes to generated HTMLs are split into a subsequent CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1476172

Bug: 906850
Change-Id: I942159ce3b57dd472fe56764772b610c0231132f
Reviewed-on: https://chromium-review.googlesource.com/c/1476144
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634993}
@hiroshige-g
Copy link
Contributor

Like previous PRs,

  • Stability bots are timing out due to the large number of affected tests.
  • Safari results are due to existing flakiness.

@lukebjerring
Copy link
Contributor

Given that the status checks for wpt.fyi don't show any regressions (of the 3295 affected subtests), let's just force-merge.

@Hexcles Hexcles merged commit 79798bc into master Feb 26, 2019
@Hexcles Hexcles deleted the chromium-export-cl-1476144 branch February 26, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants