[idle] Restrict the Idle Detection API to top-level frames #15731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1506815
branch
7 times, most recently
from
30273f6
to
161fa32
Compare
Allow only top-level frames to use the idle-detection feature by setting a default Feature Policy of "self" to allow only same-origin iframes. This check is in place to prevent third party scripts running on the page (eg. ads) from listening to a user's idle-ness. Bug: 936659 Change-Id: I0c83c29ec95cad25e9c35c339e46c79937654889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506815 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#640061}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1506815
branch
from
161fa32
to
3f2b5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow only top-level frames to use the idle-detection feature by setting
a default Feature Policy of "self" to allow only same-origin iframes.
This check is in place to prevent third party scripts running on the
page (eg. ads) from listening to a user's idle-ness.
Bug: 936659
Change-Id: I0c83c29ec95cad25e9c35c339e46c79937654889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506815
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#640061}