Handle inactive timelines for main-thread worklet animations. #15767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1512789
branch
4 times, most recently
from
e237df4
to
9015cf7
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1512789
branch
3 times, most recently
from
39b7c92
to
3d0329f
Compare
Whenever start or current time is queried or calculated, check if the timeline becomes newly active or inactive and cache the last calculated current time. - When the timeline becomes newly inactive, make the start time unresolved and apply previous current time to the hold time. - When the timeline becomes newly active, calculate start time from the hold time if resolved and make the hold time unresolved. Bug: 906050 Change-Id: I3cf8e45b9ab0edd13f3108d1a375e95409a0c1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512789 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#643534}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1512789
branch
from
3d0329f
to
b38475f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever start or current time is queried or calculated,
check if the timeline becomes newly active or inactive and cache the
last calculated current time.
unresolved and apply previous current time to the hold time.
the hold time if resolved and make the hold time unresolved.
Bug: 906050
Change-Id: I3cf8e45b9ab0edd13f3108d1a375e95409a0c1e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512789
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643534}