Turn off Clip Rect caching for elements under sticky positioned elements #15913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 18, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1526680
branch
from
1b19e8d
to
ec7b76e
Compare
For elements inside sticky positioned containers that were scrolled, the cached clip rect did not previously update the scroll position. That meant that the clip rect did not move with the contents, resulting in incorrect overlap checks in some cases. To fix this, we have to turn off caching for elements inside sticky positioned elements, because in that case the scroll is sometimes included and sometimes not, depending on whether the sticky constraint is binding. Bug: 942097, 931853, 935525 Change-Id: Ibd5810c23c8d92b6047709ed06f832acd4770a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526680 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#642524}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1526680
branch
from
ec7b76e
to
01f6e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For elements inside sticky positioned containers that were scrolled, the
cached clip rect did not previously update the scroll position. That
meant that the clip rect did not move with the contents, resulting in
incorrect overlap checks in some cases. To fix this, we have to turn
off caching for elements inside sticky positioned elements, because in
that case the scroll is sometimes included and sometimes not, depending
on whether the sticky constraint is binding.
Bug: 942097, 931853, 935525
Change-Id: Ibd5810c23c8d92b6047709ed06f832acd4770a0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526680
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#642524}