override align-items in flex-vertical-align-effect.html
#16305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #16304 by removing the (default) influence of `align-items:stretch` on the radio button flex-item, which influences its sizing/rendering regardless of the value of the `vertical-align` property (which is what the testcase is really trying to test). So, let's take that `stretch` behavior out of the equation entirely.
wpt-pr-bot
requested review from
cbiesinger,
fantasai,
kojiishi,
mrego,
plinss,
rachelandrew and
tabatkins
|
@cbiesinger, maybe you'd be up for reviewing here? (See details on #16304 - the test currently depends on https://bugs.chromium.org/p/chromium/issues/detail?id=768999 , by accident, and this pull request removes that dependency so that it'll pass in all engines.) [edit: I initially tagged username "biesi" here; apologies for spamming that person] |
cbiesinger
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #16304 by removing the (default) influence of
align-items:stretchon the radio button flex-item, which influences itssizing/rendering regardless of the value of the
vertical-alignproperty(which is what the testcase is really trying to test). So, let's take that
stretchbehavior out of the equation entirely.