Same events at the same time don't replace each other #16432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 22, 2019
Previously, if multiple events of the same type were scheduled at the same time, then each new event would replace the existing event. This is incorrect according to the spec. There is no special treatment here and events are inserted in the order in which they're received. This change only affects linear and exponential ramps. The result is that the ramp preceeds up to the first event value, and then at the event time, the output instantly jumps to the last event value. Bug: 925037 Test: the-audioparam-interface/event-insertion.html updated Change-Id: I2de32c7a71c12e5673b2db8cf81f9dc48f3ee458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577661 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#654242}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1577661
branch
from
dccf564
to
b3ff771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if multiple events of the same type were scheduled at the
same time, then each new event would replace the existing event. This
is incorrect according to the spec. There is no special treatment
here and events are inserted in the order in which they're received.
This change only affects linear and exponential ramps. The result is
that the ramp preceeds up to the first event value, and then at the
event time, the output instantly jumps to the last event value.
Bug: 925037
Test: the-audioparam-interface/event-insertion.html updated
Change-Id: I2de32c7a71c12e5673b2db8cf81f9dc48f3ee458
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577661
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#654242}