[LayoutNG] Fix propagation of forcing clearance. #16476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 24, 2019
Previously if a child cleared an adjoining float, a grandchild may be the element to resolve that subtree's BFC-block-offset. When this occurred that grandchild didn't know that it should be forced to clear a certain float. This patch propagates the "ShouldForceClearance" bit down to arbitrary grandchildren. Bug: 944083 Change-Id: Iedb023c01ff4c3aa3dd83b6e7b0cfc08afb13aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582271 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#653821}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1582271
branch
from
2117c70
to
23880e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if a child cleared an adjoining float, a grandchild may be
the element to resolve that subtree's BFC-block-offset.
When this occurred that grandchild didn't know that it should be
forced to clear a certain float.
This patch propagates the "ShouldForceClearance" bit down to arbitrary
grandchildren.
Bug: 944083
Change-Id: Iedb023c01ff4c3aa3dd83b6e7b0cfc08afb13aad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582271
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653821}