CSS: shape-outside - serialize box after shape #16679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 4, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1595194
branch
from
b310581
to
b4c6fb5
Compare
We now serialize "border-box circle(7% at 8% 9%)" as "circle(7% at 8% 9%) border-box" for consistency with spec. https://drafts.csswg.org/css-shapes-1/#shape-outside-property Value: ... | [ <basic-shape> || <shape-box> ] | ... Change-Id: Ia6692b87e4c2e98749a9f18a54341332cdb07b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595194 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#656768}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1595194
branch
from
b4c6fb5
to
c6d3a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now serialize
"border-box circle(7% at 8% 9%)"
as
"circle(7% at 8% 9%) border-box"
for consistency with spec.
https://drafts.csswg.org/css-shapes-1/#shape-outside-property
Value: ... | [ <basic-shape> || <shape-box> ] | ...
Change-Id: Ia6692b87e4c2e98749a9f18a54341332cdb07b1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595194
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#656768}