Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark disconnected tree-scopes for style update. #16740

Merged
merged 1 commit into from May 9, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented May 8, 2019

Modifying a stylesheet adopted by a disconnected shadow root caused a
crash.

Bug: 960883
Change-Id: I1f7dd5b9cc640d7d87bc8629971e828dd2e2e558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601046
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658059}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Modifying a stylesheet adopted by a disconnected shadow root caused a
crash.

Bug: 960883
Change-Id: I1f7dd5b9cc640d7d87bc8629971e828dd2e2e558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601046
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658059}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants