Rename touch tap function in pointerevent_support.js #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 10, 2019
In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. pointerevent_support.js keeps many commonly used functions in the pointer event tests. There are click function for all input types, touch, mouse and pen. So I make the current touch tap function to a general "clickInTarget" function for all inputs. Bug: 606367 Change-Id: I8da3e8910c6ec0128a40d38ce6ac21bf24c449a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604328 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#658669}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1604328
branch
from
a08bf8d
to
b0e04aa
Compare
|
This is a simple rename and the flakiness is pre-existing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs.
pointerevent_support.js keeps many commonly used functions in the
pointer event tests. There are click function for all input types,
touch, mouse and pen. So I make the current touch tap function to a
general "clickInTarget" function for all inputs.
Bug: 606367
Change-Id: I8da3e8910c6ec0128a40d38ce6ac21bf24c449a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604328
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#658669}