[LayoutNG] LayoutNGInsideListMarker inline splitting #16807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzzer caught a NULL deref crash. Running with DCHECK,
found a problem before the deref, we were cloning
LayoutNGInsideListMarker inside LayoutInline::SplitInlines.
This was triggering a DCHECK in LayoutInline::Clone.
I am not very familiar with how LayoutInline line splitting
works. I have a patch created with my shallow understanding
that fixes the crash, but I am not sure if this is the
right thing to do.
Bug: 962242
Change-Id: I11e4cf3307c257e7c396b4112888bad0cd76ac5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610522
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659286}